Skip to content

Add system property to allow host header to be added to HttpRequest#766

Merged
rhernandez35 merged 1 commit into
mainfrom
adwsingh/system-properties-hook
Jun 11, 2025
Merged

Add system property to allow host header to be added to HttpRequest#766
rhernandez35 merged 1 commit into
mainfrom
adwsingh/system-properties-hook

Conversation

@adwsingh

Copy link
Copy Markdown
Contributor

Add a hook to add system properties to the Cli

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@adwsingh adwsingh changed the title adwsingh/system properties hook Add a hook to add system properties before cli execution. Jun 11, 2025
@adwsingh
adwsingh requested a review from rhernandez35 June 11, 2025 03:32
Comment thread mcp/mcp-cli/src/main/java/software/amazon/smithy/java/mcp/cli/McpCli.java Outdated

@CommandLine.Command(name = "mcp-registry", versionProvider = VersionProvider.class, mixinStandardHelpOptions = true,
scope = CommandLine.ScopeType.INHERIT)
class McpRegistry {}

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did this have to be moved?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want any accidental class initialization before we add system properties. The annotations on McpCli were triggering some.

@adwsingh
adwsingh force-pushed the adwsingh/system-properties-hook branch from 0731e94 to 840b2e1 Compare June 11, 2025 04:18
@adwsingh adwsingh changed the title Add a hook to add system properties before cli execution. Add system property to allow host header to be added to HttpRequest Jun 11, 2025
@rhernandez35
rhernandez35 merged commit 1a2d927 into main Jun 11, 2025
2 checks passed
@rhernandez35
rhernandez35 deleted the adwsingh/system-properties-hook branch June 11, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants